Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] Combining separate device errors into single dfdx::tensor::Error enum #875

Merged
merged 4 commits into from
Oct 25, 2023
Merged

[Breaking] Combining separate device errors into single dfdx::tensor::Error enum #875

merged 4 commits into from
Oct 25, 2023

Conversation

coreylowman
Copy link
Owner

@coreylowman coreylowman commented Oct 25, 2023 •
edited
Loading

This makes it a lot easier to write neural network modules, since you don't have to constraint the Module::Error to be the same across all sub modules anymore.

In general it makes it easier to work with dfdx since there is a single dfdx::tensor::Error type for errors.

@coreylowman coreylowman merged commit 7df12c0 into main Oct 25, 2023
8 checks passed
@coreylowman coreylowman deleted the single-error branch October 25, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coreylowman